feat(BA-3668): remove unnecessary informations from model service JWT #7705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.feature.md -> 7705.feature.md Co-authored-by: octodog <[email protected]>
HyeockJinKim
approved these changes
Jan 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors JWT token generation for model service endpoints by centralizing the logic in the Circuit model and reducing token payload size. The changes move JWT creation from the endpoint API to a new model method while removing unnecessary and sensitive data from the token payload.
- Centralized JWT generation logic in a new
Circuit.generate_jwtmethod - Reduced JWT payload size by removing
configandroute_infofields - Removed direct
jwtlibrary usage from the endpoint API
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/ai/backend/appproxy/coordinator/models/circuit.py |
Added generate_jwt method to centralize JWT creation with reduced payload; added jwt import |
src/ai/backend/appproxy/coordinator/api/endpoint.py |
Refactored to use the new Circuit.generate_jwt method; removed jwt import |
changes/.feature.md |
Documentation of the feature to reduce JWT token size |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
fregataa
reviewed
Jan 13, 2026
| payload["user"] = str(created_user) | ||
| payload["exp"] = exp | ||
| # mask unrelated & sensitive information | ||
| del payload["config"] |
Member
There was a problem hiding this comment.
has config field been removed from Circuit ORM schema? If then, this could raise error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7704 (BA-3668).
This pull request focuses on reducing the size of JWT tokens generated for model service endpoints by removing unnecessary information and centralizing the logic for JWT creation. The changes streamline the payload, mask sensitive data, and move JWT generation to the
Circuitmodel for better maintainability.JWT Generation Improvements:
generate_jwtmethod to theCircuitmodel to create JWT tokens with only essential information, removing unrelated and sensitive fields such asconfigandroute_info. (src/ai/backend/appproxy/coordinator/models/circuit.py, src/ai/backend/appproxy/coordinator/models/circuit.pyR417-R431)generate_jwtmethod, ensuring a smaller and cleaner JWT payload. (src/ai/backend/appproxy/coordinator/api/endpoint.py, src/ai/backend/appproxy/coordinator/api/endpoint.pyL303-R304)Codebase Cleanup:
jwtlibrary from the endpoint API, consolidating JWT logic in the model layer. (src/ai/backend/appproxy/coordinator/api/endpoint.py, src/ai/backend/appproxy/coordinator/api/endpoint.pyL9)jwtimport to the model file to support the new centralized JWT generation method. (src/ai/backend/appproxy/coordinator/models/circuit.py, src/ai/backend/appproxy/coordinator/models/circuit.pyR5)Documentation:
changes/.feature.md, changes/.feature.mdR1)